On Mon, Nov 10, 2008 at 11:09:16AM -0800, J.C. Roberts wrote:
On Mon, 10 Nov 2008 15:08:43 -0300 Jorge Arellano Cid <jcid@dillo.org> wrote:
[...] This raises an interesting issue.
It may be necessary to add "ui_font_factor" to dillorc.
With the patch "as is" things get broken here. The popup menus get incomplete titles.
By this I assume you mean the text with the new/larger font size in the title/label on the popup menus does not fit within the provided space?
Yes.
[...] I remember reading in the fltk docs about a member function to calculate X,Y size but since dillo is my first adventure into fltk, I simply cannot recall the function name. --It's one of those "I know I saw it... but where the heck did I see it?" type of things. ;-)
measure(). IIRC, used in: the progress widgets, the download dpi, others.
Looking at the result, I realized my personal preference is to have smaller fonts in the UI, than in rendered pages. This led me to the "ui_font_factor" solution.
CVS has now a similar patch that doesn't scale the font (submitted by corvid some time ago).
It'd be good to have a patch that takes all the UI elements into account. Unfortunately, a patch that scales UI fonts may also need to scale the UI panel and this could take some effort.
Scaling the UI font without scaling the UI panel may be easier, and also serve the purpose.
Keeping the UI usable/readable across a multitude of systems and configurations is a different problem than keeping the displayed web pages usable/readable. It's best to address each problem individually, rather than lumping them together.
That's what I meant.
Though it would be a serious change, and require a lot of patching, I think the best solution is to have a two pronged approach:
1.) Font Factor (scaling) 2.) Font Size
If only Font_Size is stated, it would be used verbatim. If only Font_Factor is stated, it would scale the font. if both were stated, Font_Factor would take precedence.
This would give you prefs for:
vw_font_name vw_font_size vw_font_factor
ui_font_name ui_font_size ui_font_factor
Looks OK. Code for handling those extra prefs is OK. Lots of code to recalculate widget sizes to acomodate larger fonts in the UI is not the goal. Simple code that solves the problem is welcomed.
Ummm... with all due respect, I think the currently used "fontname" in the prefs is against the coding conventions stated on the dillo site. Of course, it really doesn't matter to a compiler, but if I'm going to dig into augmenting this code, I need to know the "right" (TM)(C)(R) way to fix it. :-)
Sorry, I don't understand. -- Cheers Jorge.-