Hi Jeremy, On Thu, Jun 05, 2008 at 06:25:33PM +0100, Jeremy Henty wrote:
This patch moves some function declarations from html.cc to html_common.hh . It only does *some* of the renaming because the full patch breaks the list's moderation limit. I'll follow up to this message with the rest of the renaming. You may want to batch this patch and the followup together as a single commit.
Please comment!
With regard to big patches and splitting, please don't burden yourself with splitting. This is just cleanup so please send me one big patch to my email address not dillo-dev. After applying thwe full patchset, I got compiler errors. :( <quote> g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I../../dw-testbed -I/usr/include/libpng12 -I/usr/local/include -I/usr/include/freetype2 -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -MT form.o -MD -MP -MF .deps/form.Tpo -c -o form.o form.cc form.cc: In member function 'void DilloHtmlInput::reset()': form.cc:1413: error: jump to case label form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1414: error: jump to case label form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1419: error: jump to case label form.cc:1415: error: crosses initialization of 'dw::core::ui::ToggleButtonResource* tb_r' form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1434: error: jump to case label form.cc:1415: error: crosses initialization of 'dw::core::ui::ToggleButtonResource* tb_r' form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1449: error: jump to case label [...] </quote> To solve this problem, please send me one big patch with all the changes. I'm not committing anything yet. -- Cheers Jorge.-