Indan Zupancic wrote:
Hi,
Things I noticed:
Frames with zero border aren't supported.
Known problem, Dw (actually it is GtkDwScrolledFrame) is not able to draw borderless frames (this was in the README for many releases, but I got tired of repeating it so dropped it after README-11). As I did not want to hack to much around the widget (Sebastian's domain) I did not change this. Yet.
When there is a scrollbar in a frame it has a fat border to the left, making it a little bit ugly, even wider than it already is, and making it look more a part of the right frame because there is no such border at that side (see www.xenon.nl for what I mean, or any other site with similar frames).
Also a widget issue, but it is definitely more visible (and annoying) in framed document.
Reload doesn't reload all the frames. Known issue, but still annoying. :)
Thus far I have not made any special-case exceptions for framed documents wrt. history etc. As there seem to be many requests for this, I think I can not get around this... Should not be hard (just have reload etc. work on document subtrees instead of single documents) but has not been done yet.
Other issues:
When resizing a vertical frame, a horizontal scrollbar is rendered in a blinking way, even when it's not needed. This seems to appear only if a scrollbar will be rendered when the frame doesn't fit, so when you'll never see one it won't blink while resizing either. I guess this is the case with horizontal frames too, but didn't find one to test it with (example url: http://members.ams.chello.nl/wasscher/weer/). Should be easy to fix, I guess initializing the size to 0xffffffff or something instead of 0 at the right place could fix it, if it isn't a GTK issue.
Which it might just be... or not. I've played around with some configurations way back when I started this patch, but have not given it any attention afterwards. I'll see if I can find something to make it look less blinky (maybe hide scrollbars when resizing?).
Also the history seems very broken/buggy with framed webpages. Only thing that worked for me on one page was forward/backward for the main frame, and for most other sites there doesn't seem to be any history for frames at all, even right-clicking gives no forward/backward options (know issue I assume).
The latest patch (version 16) has navigation menus for all frames, in the 'This Frame...' submenu. These work fine AFAIK, if they don't please tell me what breaks where and I'll have a look at it. Individual document history (where 'document' signifies a single display frame/window) should work fine as it is now; adding cascaded reload and possibly some history update for frmae navigation should do the trick I guess?
Another one: Could you please edit your version of capi.c slightly, so that I don't have to make a seperate version of my patch? Just an extra #ifndef HTTPS / #endif somewhere, so it won't affect your code at all.
I'll add it to the next version. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]