On Wed, Jan 07, 2009 at 09:07:19PM +0100, Johannes Hofmann wrote:
Hi Jorge,
On Wed, Jan 07, 2009 at 03:56:55PM -0300, Jorge Arellano Cid wrote:
On Wed, Jan 07, 2009 at 01:19:38PM -0300, Jorge Arellano Cid wrote:
On Tue, Jan 06, 2009 at 01:37:10PM +0100, Johannes Hofmann wrote:
On Mon, Jan 05, 2009 at 02:51:03PM -0300, Jorge Arellano Cid wrote:
Hi there,
With Johannes, we're trying to find out why valgrind complains on the newest CSS branch with a certain URL:
$ valgrind --tool=memcheck --leak-check=yes \ ./dillo http://selenic.com/pipermail/mercurial/ &>out
$ less out
There're several "Invalid read of size 1".
It doesn't complain with a local file, nor after repush. It seems the timing is important, and maybe the decoder...
The problem seems to be that at cache.c:1149 data is assigned entry->UTF8Data, then during Html_callback() a_Cache_set_content_type() get's called which since revision 48029b8a5478 frees entry->UTF8Data. That also explains why the earlier read of start went ok.
I don't really now how to fix that though...
Good news: now I have a big cleanup patch that gets rid of every valgrind complain on that page!
jcid@d620:~/C/Dillo/d2/dillo-css-wc2/src$ diffstat try2.diff cache.c | 157 ++++++++++++++++++++++++++++------------------------------------ cache.h | 3 - capi.c | 5 -- capi.h | 3 - html.cc | 22 ++++++-- 5 files changed, 89 insertions(+), 101 deletions(-)
Let me polish it a bit more before you review and test it.
Here go the patches attached. For test, review & commments. Please apply styleengine-init-values first.
This patch fixes these crashes for me. I think we should reintroduce the force parameter given corvid's comment.
Yes, sure. It was stripped because it wasn't used. Good to know it works! -- Cheers Jorge.-