25 Mar
2009
25 Mar
'09
3:08 a.m.
Joerg wrote:
On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote:
Jorge wrote:
Skimming the code it looks like the cast to long for int is the way to go. If a:
- URL_DATA(url)->len, content_type->str, + (long)URL_DATA(url)->len, content_type->str,
solves it. I'd commit it and let the explanation come after the patch.
I was thinking of adding long casts for the Content-Length headers in file.c as well. Sound good?
Shouldn't that be (s)size_t? At least one vendor was smart enough to produce a 64bit platform with long != ssize_t and support for files larger than 32bit sounds highly useful...
Well, you know these issues better than I do. These two cases use %ld currently. One is given a size_t, and one is given an off_t.