On Thu, Sep 18, 2008 at 06:01:51AM +0100, Jeremy Henty wrote:
In dillo2/src/ui.cc, CustInput::handle() has a comment saying that it disables CTRL+{o,r,HomeKey,EndKey}, yet it only seems to disable CTRL+o . I think CTRL+r used to be disabled too, so that CTRL+r would reload the page even if the URL widget had the focus. Here's a one-line patch to restore that.
Yeah, CTRL+r wasn't explicity disabled but it worked. Committed the ignore code at CustInput though (it's cleaner).
What should we do about CTRL+{HomeKey,EndKey}? I prefer HomeKey and EndKey to scroll the main window even when the URL has the focus. Wasn't that the behaviour originally? It certainly doesn't happen now.
AFAIR {HomeKey,EndKey} had always go to begin/end of the text in the Location (when focused), and that's the expected bahaviour. Committed Ctrl+{HomeKey,EndKey} to keep working on the main area even with Location focused. -- Cheers Jorge.-