On Fri, May 15, 2009 at 03:32:47PM +0000, corvid wrote:
Tim wrote:
I would prefer to fix the callers of a_Html_get_attr() instead.
Thanks, you are right. My patch was just a quick-and-dirty solution though. Certainly it can be done better.
Could you please post the compiler errors you get with current tip?
Yes, but I only can give you the first error. Otherwise I would need to apply the patch partially. But to get an idea of the issue, this should be sufficient yet (the other errors were quite similar).
[...] mv -f .deps/table.Tpo .deps/table.Po g++ -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT tablecell.o -MD -MP -MF .deps/tablecell.Tpo -c -o tablecell.o tablecell.cc tablecell.cc: In member function ???virtual void dw::TableCell::wordWrap(int)???: tablecell.cc:55: error: invalid conversion from ???const char*??? to ???char*??? make[2]: *** [tablecell.o] Error 1 [...]
So these all boil down to GCC 4.4 wanting strchr and strrchr to return const char* when passed a const char* ?
Yes. It's concisely explained here: http://gcc.gnu.org/gcc-4.4/porting_to.html -- Cheers Jorge.-