Hi There!
This didn't help, bookmarks disappeared succesfully with this patch too. This time file contained lastly added bookmark in section ":s0: Unclassified" (this section didn't exist before) and i think that it happened, when i added this bookmark.
On Sun, 23 Feb 2003, John Bradford wrote:
Since I started using using 7.0, my bookmarks have been lost on four occasions, but I haven't been able to reproduce the bug at will - has anybody else noticed this?
Unfortunately this is a perverse bug: when you get accustomed to using the new bookmarks, the probability of it happening increases. I'm attaching a patch to fix it, but please let me explain the bug a bit: it happens when the bm server receives a modification request (add/modify/delete) before it has loaded the bookmarks file the first time. As most of these operations are accessed through the "modify" page (which loads the bookmarks file), they're safe, but "Bookmark this page", from the pop-up menu, is the exception. So why it was so hard to hunt? Because when you start dillo and it launches the bm server for the first time, it's vulnerable, but most probably your first action with the bookmarks will be to see them. After this first request, the bug can't happen again. If you close dillo, the bm server will remain sleeping, so if you run another dillo and issue a bare "Bookmark this page", the responding server will be the same you used the first time, so no bug can happen! The only way (AFAICS) to reproduce it, is to kill the server and issue a "Bookmark this page" operation before any other bookmark operation. How can this happen with "normal" use? Start dillo, surf the net and use bookmarks happily. At night, turn off your computer. Next day, start surfing, find a nice page and bookmark it before looking at your bookmarks. The patch: This patch does two things: 1.- Keeps a backup of the bookmarks file: bm.txt.bak 2.- Avoids not loading the bookmarks file by issuing a conditional load before any operation. Notes: * The backup file is made by renaming the original file, so if a write error happens the backup remains! * The backup is made when the original file has a size greater than 256 bytes (just in case!). Please test it as hard as you can. Livio: please add a warning message in the front and help pages of our site with a link to the patch and with the instructions to apply it. Please also state that a new release, fixing this bug will be done ASAP. Sebastian: Don't worry about the copy&paste work, it will not be included in this bug-fix release. Cheers Jorge.-