Hi Francis, Thanks for the good feedback. On Wed, Mar 22, 2006 at 09:21:21AM +0000, Francis Daly wrote:
On Tue, Mar 21, 2006 at 02:13:38PM -0400, Jorge Arellano Cid wrote:
Hi there,
... test and send feedback.
Some minor thing that you might like to tidy before release:
* ChangeLog has a few entries with a leading hyphen.
Yes, this visually separates batches of patches by the same authors.
* ChangeLog says
* Added dpi/downloads.cc (Default FLTK2-based GUI for downloads dpi). and * Made the downloads plugin dillo-cookie aware.
It's only the *old* plugin which handles cookies. (And modifying the new one to is more than just a two line addition, because the arguments are counted in (I think) two other places.) But overall, it's no regression from 0.8.5, so no problem. It just might be worth clarifying the distinction.
Ooops. This is a BUG! I'll clarify the distinction in rc2.
* README says
Here's a list of some well known problems:
* no FRAMES rendering * no https -- read the FAQ to enable a protoype.
while the code now defaults to https enabled. Change README or change dpi/https.c
If you choose to change README and you want to keep at least two problems, you could mention "javascript" or "http authentication". But only if you consider their absence a problem ;-)
Leaving https enabled will get the code tested more, but will likely cause a warning for each https: url accessed, unless the user's distribution happens to store trusted root certs in /etc/ssl/certs.
You can choose whether you want https.c polished more before being exposed to the world. Possibly a note in README or FAQ saying "dillo reads root certs from the directories /etc/ssl/certs or $HOME/.dillo/certs; they should be named after the hash of the certificate subject name -- see e.g. the openssl x509 documentation, '-hash' option for more information."
Yes, this needs some fixes. I'll disable the https dpi as usual (it's too rough now, and it needs a conversion from dpi filter to dpi server too). Sending the users to dig the openssl x509 documentation is too much, and the https dpi hangs when there are concurrent https requests. As for the known problems, I'll add "http authentication". :-)
(Yes, I know, if I *really* cared, there'd be patches in this mail. But I'm not sure if you're looking at releasing in a day or a week, and think the things should be mentioned early so you can consider whether you want to change any of them.)
I think more or less one week. Until the release candidate is tested and not having new problems. -- Cheers Jorge.- PS: Your email reply was addressed to me, not to the list. (usually a MUA choice that needs a tweak)