Hi,
Works fine for me!
Thanks! I have also added two other improvements (last ones I promise). Clicking on the up and down buttons of the scrollbar in page mode jumps to the top and bottom. And scrolling a full page, now takes into account if the horizontal scrollbar is visible or not when computing the overlap, so the number of pixels of overlap you specify are always duplicated in the next page. Now I'm starting to miss the page scrolling mode in other programs...
Also, do you usually set focus_new_tab to NO?, I'm considering switching the default to NO. Same with show_quit_dialog.
I set 'NO' for both of those, but can understand why the original decision was made to default to 'YES'.
I think that Dillo was originally trying to cater to beginners and people unfamiliar with how a browser works, but times have changed and maybe adjusting some of these defaults would better serve our actual userbase.
I agree. Okay, so I will flip those then.
In my opinion this should also be the default: right_click_closes_tab=NO
It may be a matter of preference, but that is how the other browsers do it. Most people are probably used to using the middle click for this, and so having it close the tab with the right click might be unexpected and undesired.
I decided to leave on YES for a simple reason: the laptop I was using Dillo on didn't have a middle button, so the only way to close the tabs was to press both buttons at the same time to emulate the middle one (or the X button). So I assumed that it is possible that the same scenario happens to other people too which only use an old laptop, and they may think that the only way to close tabs is on the X button on the right, as we don't have an X over each tab. Of course you can always change it to your preferences, but I think it is a safer default this way to be easily discovered. In any case I have not done any research to back my claims. On my desktop I also use the right button, because I don't like clicking the mouse wheel (I think in my mouse is really hard to press), but this doesn't justify the defaults. I would also prefer opening new tabs without the mouse wheel button or the keyboard. So far I can to by clicking and holding the right button, dragging a couple of pixels to the right to open in a new tab, then releasing it. I'm thinking it may be nice to make this work without the need of dragging, so by default it selects open in a new tab. We can place a threshold to not consider quick press and release events to cause the selection to be clicked. The same may be also doable with the left button, so if you click but keep it pressed for a configurable threshold it is opened in a new tab (of the other way around). Best, Rodrigo.