Jorge wrote:
On Mon, May 16, 2011 at 01:17:45AM +0000, corvid wrote:
Jorge wrote:
On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote:
if eval "test x$GCC = xyes"; then .. if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then CFLAGS="$CFLAGS -W -Wno-unused-parameter" fi fi .. fi
It checks for 3.x specifically. 3.0 came out on June 18, 2001.
And of course 4.x has been out since...let's see...April 20, 2005.
2.95 was still apparently around back in http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , which prompted this code at the time.
Can I rip out the version-checking and make it into an ordinary case of adding the argument if it isn't already in CFLAGS?
Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, not -Wunused-parameter. Why do we want this?"
Some callbacks don't make use of default parameters and this option avoids a lot of noise (making it simpler to spot other warnings).
I know we had that one in a_Http_ccc() that is suppressed with a (void)Data2; but I never see any other warnings around.