Hi Johannes, On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote:
Hello,
as I didn't get any feedback from Sebastian yet on my proposal to make the scrollbars part of UI instead of FltkViewport, I decided to split my initial patch. Below is a version that still uses a PackedGroup in UI, but leaves the scrollbars in FltkViewport. Here comes the details:
* Make scrollbars really children of FltkViewport, as it was probabely intended. * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. * Adjust draw() and handle() so that scrollbars work properly. * As a consequence replace() now works properly, so remove the workaround. * Make TopGroup a PackedGroup and let it do the layout. * Simplify fullscreen mode.
This also fixes annoying problems with the statusbar when new windows are created in fullscreen mode.
Reviewing the patch made me remember the struggle I had, to develop those workarounds to have the UI working. As you may intuit I'm more than willing to commit. ;-) The question is: Do you agree with commiting now or do you prefer to hold them for comment as the former patch? -- Cheers Jorge.-