On Thu, Jun 19, 2008 at 08:48:48PM +0100, Jeremy Henty wrote:
On Wed, Jun 18, 2008 at 08:35:57AM -0400, Jorge Arellano Cid wrote:
Committed, except 00 and 05.
00: The stash buffer may hold a script, in that case parse_stash is not as clear as parse_entities.
Would a better name make the change acceptable? For instance, Html_parse_stash_entries() ?
Html_parse_stash_entities() ? Why is it better than the traditional a_Html_parse_entities()?
05: gives compilation errors: [...] form.cc: In function 'void Html_option_finish(DilloHtml*)': form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* DilloHtmlSelect::options' is private form.cc:1918: error: within this context form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* DilloHtmlSelect::options' is private form.cc:1918: error: within this context
That's because not committing 00 breaks one of the chunks in 04 so you still have an explicit ->inputs which should have been replaced by a call to getCurrentOption() . I'm appending the missing chunk of 04 and resubmitting 05 .
Committed. -- Cheers Jorge.-