On Mon, Jun 23, 2008 at 05:05:29AM +0000, corvid wrote:
In SELECT, if standard_widget_colors is set, color and backgroundColor are set to NULL. This tells FltkResource::setWidgetStyle() to leave the colors on the widget alone.
If an inline element inside a SELECT calls style->color->getColor() or style->backgroundColor->getColor(), we get that crash.
This currently means FONT and IMG. OBJECT and A would as well if that a_Color_vc code were uncommented.
options: - four IN_SELECT tests. - letting Html_stack_cleanup_at_open() be called for inline elements in order to close the SELECT or something if IN_SELECT and the new tag isn't OPTION or OPTGROUP. - generating our own standard widget colors to put into color and backgroundColor.
I don't like the first one because someone innocently adding a getColor somewhere in the future will never know about this danger. (a good example would be adding the a_Color_vc to open_frame())
Without a deep understanding of the code involved, I'd prefer the third option (standard widget colors) as it looks more general and simple as a solution. -- Cheers Jorge.-