Jeremy wrote:
On Fri, Nov 20, 2009 at 09:28:25PM +0000, corvid wrote:
Jeremy wrote:
It's interesting that FLTK decides to clip a little bit from the end there. I wonder what it was thinking...
Me too, but I didn't feel like wading through FLTK code tonight! :-)
Turns out that it doesn't do it to me when I run it. So let's blame the font...
We just copy the pointer to the DilloUrl structure, so we are assuming it will never be free()-ed while the menu is up. If I'm wrong about this the patch will need to be revised.
I don't know the details of when Jorge's code decides to free cache entries, but I think it would be best not to assume that the url remains valid.
OK, I agree: robust code should ensure its own safety, not depend on other code to look after it. Here's a patch to do that. It applies on top of the previous patch.
Committed.