* Frank de Lange <frank@unternet.org> [09-25-03 08:39]:
Those of you who have tried my tab/frames patch will know that I usually make all 'extra' features optional. This allows those who {do not {need|like}|can not afford} those features to leave them out of the resulting binary. However, it also makes the code somewhat more complex, as the optional features are enabled/disabled through conditional compilation (#ifdef/#ifndef....#endif). The space saved by leaving out tabs and frames is currently about 25 kilobytes (Kib, kB, KB, choose your acronym...).
I have gotten some comments on this, suggesting the removal of these conditional statements. This way, Dillo would ALWAYS have the extra features (tabs and frames).
Before I say 'yes' or 'no' to these suggestions, I'd like to know what your thoughts are on this.
So, speak up. Have a look at the code (look for #ifdef XHTML_DTD_... #and ifndef DISABLE_FRAMES) and tell me whether the savings in space #are worth the added complexity...
IANAP, but why not control the _optional_ FEATURES thru the rc file, (on/off, yes/no, 1/0)? -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org