----- Forwarded message from Jorge Arellano Cid <jcid@dillo.org> ----- Date: Thu, 6 Nov 2008 14:05:33 -0300 From: Jorge Arellano Cid <jcid@dillo.org> To: Johannes Hofmann <Johannes.Hofmann@gmx.de> Subject: Re: css prototype on freehg.org On Thu, Nov 06, 2008 at 05:31:34PM +0100, Johannes Hofmann wrote:
I'm currently reviewing the CSS work you uploaded!
On Fri, Oct 31, 2008 at 05:00:54PM +0100, Johannes Hofmann wrote:
Hi Jorge,
I just created a repository http://freehg.org/u/jh33/dillo-css-prototype/
freehg.org is a free mercurial hosting service. This gives access to the newest version of the css prototyping work. Also you can check whether you like mercurial.
Hmm, that's another topic that needs a resolution: to git or to hg?
Featurewise there is hardly a difference. I prefer mercurial because of it's nice and simple ui. Just recently there was the same discussion for DragonFlyBSD: http://leaf.dragonflybsd.org/mailarchive/kernel/2008-10/msg00144.html
Yes, I also like simple UIs.
[...] Do you have a recommended quick-start guide?
http://www.selenic.com/mercurial/wiki/index.cgi/QuickStart
and a bit longer:
http://www.selenic.com/mercurial/wiki/index.cgi/Tutorial
and a lot longer:
Thanks.
I didn't send this to the list, because I want to be sure that you are ok with this step.
Which one, the mercurial or the CSS code?
Both. Publishing CSS prototype in a separate repository.
For now the Hg repository is OK. I'm yet to grasp the distributed workflow model. It seems our old CVS needs an update.
As far as CSS, after the first review it looks OK, and seems the way to go. I'm going more in depth now to try to understand how it works and fits in the plan.
Great. Please keep in mind that the current work tries to find a proper interface between CSS stuff and the code in html.cc. It needs to be verified that the concept covers all the edge cases. One is probabely the table code that stores a separate table_cell_style on the stack. Is this to hold cell properties that were set in the <table> or <tr> tags?
I'll check. Most probably that's the case though. e.g. bgcolor. OK, once I've grasped the concept, I'll tell you what I find.
Also the CSS prototype contains some code from dillo-0.8.0-css-3 that doesn't have license headers. Can you contact Sebastian to ask if it is ok to use stuff from his prototype?
I have an email from him (long time ago) where he advocates on making the CSS prototype code more visible from the website, to attract developers. He also said he was working on floating objects!
I'll try to contact him and see what's up with him...
As from his email, and conversations we had long ago, I believe it's quite safe to use the code.
Great. It seems to contain a pretty complete CSS parser.
Cheers, Johannes
PS: We should probabely take this discussion to the list. It's a bit quiet there. What do You think?
Sure, feel free to forward the thread (or relevant parts). -- Cheers Jorge.- ----- End forwarded message -----