Hi, On Sun, Jan 13, 2008 at 05:07:04PM +0100, Thomas-Martin Seck wrote:
All,
I am very glad to see that dillo-fltk has now gained some momentum.
We too! ;)
While looking at it on FreeBSD (6.2) I came across some minor problems, patches for which are attached:
1) detect_libiconv.diff
src/decode.c uses iconv_open but - at least on FreeBSD - libiconv is not in the default linker path, making the build abort. Add a simple test to configure.in to check for libiconv's presence and usability and a substitution for ICONV_LIBS to src/Makefile.am.
OK with the idea but the patch "as is" breaks it for Linux. Please send a new one.
2) src-colors.h.diff
I needed to include <stdint.h> or <inttypes.h> in order to have int32_t properly defined. I decided to wrap this include in a hopefully portable and correct way by instrumenting config.h.
Committed.
3) src-dns.c.diff
On current FreeBSD releases, netdb.h does no longer define EAI_NODATA, it had been marked as obsoleted there and #if 0'ed out since Oct 2003. It therefore cannot be checked for on a current FreeBSD release, so test whether we are either compiling on something other that FreeBSD or if it's a 4.x or older FreeBSD release. Other BSDs might have similar issues in this regard.
Committed, with Johannes' suggestion.
Otherwise dillo-fltk looks really promising -- keep up the good work!
I'd like to know in what sense it looks "promising" to you. -- Cheers Jorge.-