On Mon, May 04, 2009 at 06:59:34AM +0100, Jeremy Henty wrote:
Three more cleanup patches:
1: Inline Cache_client_make_key() into Cache_client_enqueue(). Why have a separate function just to increment a variable? It's just as clear (and less noisy) to increment a static variable inside Cache_client_enqueue().
Committed.
2: The width and height arguments of a_Image_new() do nothing. The function itself ignores them and its callers always set them to 0. Since neither the function or its callers seem to care what these arguments are, why not remove them?
Committed.
3: a_Web_dispatch_by_type() has a strange convention for its return type, it returns -1 to indicate failure. It's less confusing to use the common convention of a boolean: 1 indicates success and 0 indicates failure.
It's not strange. Just like libc: 0 success, < 0 error, > 0 success with return code. -- Cheers Jorge.-