On Fri, Aug 26, 2011 at 10:20:43AM +0200, Johannes Hofmann wrote:
Hi,
I found that current dillo uses twice the given margin-bottom: value. See attached margin_bottom.html. It is related to commented out code in textblock.cc. Attached patch tries to fix it while not breaking the test cases in http://www.dillo.org/test/img/ I'm not 100% sure about removing the "if" in Textblock::wordWrap(), but why shouldn't a widget's top margin count in the first line of a paragraph?
AFAIR there was the "line1" offset stuff (which seem not to apply here because it's horizontal), and the handOverBreak() code which dealt with spacing between textblocks. I'm for applying the patch, but would give first a second look to handOverBreak() just to be sure. BTW, after a quick review it looks weird, as the value seems inherited (copied from previous stack object) most of the time... -- Cheers Jorge.-