On Tue, 2 Dec 2003, David McKee wrote:
On Tue, 2 Dec 2003, Jorge Arellano Cid wrote:
On Tue, 25 Nov 2003, Andreas Schweitzer wrote: [attribution to me lost]
my gcc doesn't believe in -Wno-unused-parameters, [snip] Attached is a patch [snip] Commited. Does it work for you David?
Perfectly. Thanks.
Having said that on the basis of my gcc 2.95 based debian machine at home, I tried it on my work machine. The Redhat box actual uses: $ gcc -v Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release) *sigh* My attempts to read the auto<whatever> docs last week were very depressing, so I just looked at configure.in, and ponied up this fix: ========== --- dillo/configure.in Wed Dec 3 11:48:31 2003 +++ dillo_tweaked/configure.in Wed Dec 3 11:32:18 2003 @@ -201,7 +201,9 @@ if eval "test x$GCC = xyes"; then fi if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then if test "`$CC -v 2>&1 | grep 'version 2'`" = ""; then - CFLAGS="$CFLAGS -W -Wno-unused-parameter" + if test "`$CC -v 2>&1 | grep 'version egcs-2'`" = ""; then + CFLAGS="$CFLAGS -W -Wno-unused-parameter" + fi fi fi if test "`echo $CFLAGS | grep '\-Waggregate-return' 2> /dev/null`" = ""; then ========== which simply adds anther test to exclude gcc 2.* based egcs releases before sticking in the new flags... Style question: Would it be better to test for the presence of the flag than to try to exclude those compilers without it? Anyway, thanks for the work. -- -- David McKee -- dmckee@jlab.org -- (757) 269-7492 (Office)