-----Urspr?ngliche Nachricht----- Von: Jorge Arellano Cid <jcid@dillo.org> Gesendet: Do 21.10.2010 13:49 An: dillo-dev@dillo.org; Betreff: Re: [Dillo-dev] major commit upcoming
On Wed, Oct 20, 2010 at 10:05:28PM +0200, Johannes Hofmann wrote:
On Wed, Oct 20, 2010 at 12:39:37PM -0300, Jorge Arellano Cid wrote:
On Tue, Oct 19, 2010 at 09:11:41PM +0200, Johannes Hofmann wrote:
Hi,
just a headsup, that I plan to commit some changes for the CSS on <HTML> element issue that involve quite a few files. Basically it is a minor API change for StyleEngine, but as StyleEngine is called from quite a few places, the patch is rather big. Please let me know in case this is inconvenient atm.
On my part, go ahead. I'm still working on the collapsing border code.
Ok then - here you go....
Basically the changes are to fix the problem that CSS for the <HTML> element was not evaluated (reported by Jeremy). But the changes in StyleEngine will also help to implement dynamic style changes in the future (as needed for :visited :hover :focus etc).
As always please report any regressions...
It looks like it will help me! (inherit nonCSS stuff)
Right, I moved this functionality from html.cc / table.cc into styleengine.cc.
---
BTW, I had a hard time with border collapsing, because after adapting dillo to render my test cases as Firefox, other tests showed big differences. It was after digging into cell_props, resetValues, {pre, post}processAttrs, parser, etc... that I found the problem: dillo is not discarding CSS with syntax errors:
Generally dillo should discard CSS with errors, but there are some cases where it doesn't. I will look at your test case when I'm at home.
Note1: I tried pushing to hg css_compat, but it didn't work. My local repo behaved as the push was successful but no changes were made in the remote one (setting hofmann as trusted in my local hgrc didn't help either).
Note2: index.html has 644 permissions
Ok, I will check that.
Note3: I'll work a bit more on the collapse patches and get back to you before committing.
Note4: Considering the extensive use of "html->styleEngine", I'd use something similar to HT2TB, S_TOP macros. This is: SE(html) <=> html->styleEngine SE(html)->setNonCssHint <=> html->styleEngine->setNonCssHint I can quickly make a patch if you agree.
Yes, sure. Maybe an inlined method in DilloHtml like DilloHtml::setNonCssHint(...) { styleEngine->setNonCssHint(...); } would result in even shorter lines: html->setNonCssHint(...) Cheers, Johannes