Johannes wrote:
On Sat, Sep 18, 2010 at 02:44:20AM +0000, corvid wrote:
Johannes wrote:
Please test attached patch. It is a bit more involved than I had hoped, but it seems necessary after looking at the spec.
en.wikipedia (with remote css off) gives me "** WARNING **: No background color found!" msgs.
Yes, I think this is because I had to remove the background-color property from the user-agent style in css.cc. It's a bit weird: The spec says, that the canvas color should either be the background color assigned to the <html> tag, or if that has no background color, it should be the background color of the <body> tag. So we can't no longer set a background color in the user-agent style. If we assign it to the <html> tag, we will see a weird frame if page authors set a background-color on the <body> tag. If we assign it to the <body> tag, pages that set the background-color for the <html> tag will have a frame.
So maybe we need to reintroduce the bg_color dillorc option to set a background-color if the page has no background-color on neither the <html> nor the <body> tag. Opinions?
Is it incorrect for dillo to have a body textblock smaller than the whole page? (I remember looking into this when we couldn't pop up menus below the bottom of the textblock, and I think it was either not quite trivial, or ugly to deal with, but if we accumulate other ugliness to work around it...)