On Thu, Apr 17, 2008 at 05:28:34PM +0200, Johannes Hofmann wrote:
On Thu, Apr 17, 2008 at 08:53:23AM -0400, Jorge Arellano Cid wrote:
On Tue, Apr 15, 2008 at 09:18:23PM +0200, Johannes Hofmann wrote:
Hi Jorge,
On Tue, Apr 15, 2008 at 02:38:35PM -0400, Jorge Arellano Cid wrote:
Hi Johannes,
On Tue, Apr 08, 2008 at 05:01:41PM +0200, Johannes Hofmann wrote:
Hi Jeremy,
On Tue, Apr 08, 2008 at 07:35:25AM +0100, Jeremy Henty wrote:
On Sat, Apr 05, 2008 at 05:01:52PM +0200, Johannes Hofmann wrote:
> Attached is a patch that enables double buffering for partial screen > redraws (this is where the flickering is most annoying). You will > need at least version r6079 of fltk2 to test.
OK, I've upgraded to the latest FLTK2 snapshot (r6087) and your patch (fixed version). Looks OK so far. Any tests I should run?
Mostly I would be interested whether it still feels fast. And any regressions you observe, of course...
I found something that looks like a bug in double buffering (it doesn't happen with the previous code).
If you:
- ./dillo-fltk about:splash - scroll down 1 or 2 inches. - browse to another URL. - press right mouse button over Back button and return to the first page.
You'll end looking to the page through a window artifact in the control panel. i.e. The page rendering seems to start from below the control PANEL.
Please give it a look.
Patch 1 should fix the problem.
Good!
Committed.
The second patch removes the push_clip() / pop_clip() pair that is no longer necessary with double buffering (we only copy the needed rectangle from the backBuffer anyway). It might result in artifacts when running with --disable-doublebuffer however. So I'm not sure if you want to commit that part.
I'd commit bracketed as:
#ifdef NO_DOUBLEBUFFER push_clip (viewRect); #endif
[Drawing code here...]
#ifdef NO_DOUBLEBUFFER push_clip (viewRect); #endif
Would it be OK?
Yes, of course.
Committed. -- Cheers Jorge.-