12 Jun
2008
12 Jun
'08
11:30 p.m.
On Thu, Jun 12, 2008 at 09:56:49PM +0200, Johannes Hofmann wrote:
yOn Wed, Jun 11, 2008 at 11:36:29PM +0100, Jeremy Henty wrote:
On Wed, Jun 11, 2008 at 09:51:17PM +0200, Johannes Hofmann wrote:
I think even hashValue() should not access uninitialized data. Not only because of the annoying valgrind messages.
Got it! It's StyleAttrs::textAlignChar ! If I add "textAlignChar = '.';" to StyleAttrs::initValues() (which StyleAttrs::resetValues() already does!) then the valgrind warnings disappear. Only a_Html_tag_set_align_attr() sets textAlignChar , but it only does so if it sees "align='char'".
Great. So it's just this inititialization missing. Patchlet attached.
Committed. -- Cheers Jorge.-