On Sat, May 24, 2008 at 03:22:10AM +0000, corvid wrote:
Jeremy wrote:
Dillo crashes as follows: * Point Dillo at http://starurchin.org:8080/dillo/here * Click the "There" link. Dillo is redirected back to the "Here" page. * Click the "Reload" button. * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if (URL_FLAGS(url) & URL_Post) {" because url is NULL.
I noticed this a few weeks ago but only just found a simple way to trigger it. Any ideas why this is happening?
The problem went away when I tried the attached change, but I may be treating the symptom rather than the disease.
It must not be the result of a very recent change, because I have a dillo from April 8 that crashes doing this.
diff -pur dillo2/src/nav.c dillo2-cur/src/nav.c --- dillo2/src/nav.c 2008-05-10 20:02:22.000000000 +0000 +++ dillo2-cur/src/nav.c 2008-05-24 03:03:50.000000000 +0000 @@ -185,6 +185,8 @@ static void Nav_stack_clean(BrowserWindo void *data = dList_nth_data (bw->nav_stack, i - 1); dList_remove_fast (bw->nav_stack, data); dFree(data); + if (bw->nav_stack_ptr >= a_Nav_stack_size(bw)) + bw->nav_stack_ptr = a_Nav_stack_size(bw) - 1; } }
Committed. -- Cheers Jorge.-