Hi, On Tue, Dec 04, 2007 at 02:42:32PM +0100, Johannes Hofmann wrote:
Hi Jorge,
Committed!
Thanks. Attached is another patch that has some improvements to that code:
Excellent.
Committed.
until now, just the Changlog has been commited, right?
Right, my mistake. :-P Committed again.
If not, even when I'm not an expert in dw2, I'd prefer to push forward development in that area and to commit what looks OK. Sebastian will always have the opportunity to comment/fix later.
Regarding the scrollbars there is something fishy in the current code that needs fixing: The scrollbars are created in the FltkViewport constructor and they are drawn on the screen area belonging to FltkViewport. However from fltk point of view they are children of TopGroup.
Yes, we know there's something fishy there because while in Germany we discovered scrollbars worked without the line that was supposedly drawing them! :-)
I think this is the reason why fltk replace() does not work properly.
However, my proposed fix is really quite radical and I would want to wait for a comment from Sebastian before we head into that direction.
OK.
As a matter of fact I'm working of improving table rendering now, and I already have some code that works. It's a complex area that needs some work but I hope to commit a patch this week.
BTW, did you receive comments on the patch that lowered CPU consumption when gliding the mouse over pages full of links?
No, but the change is not that dramatic, so I think it can be applied. Do you need a patch against current cvs?
Committed. -- Cheers Jorge.-