On Thu, Mar 12, 2009 at 08:38:21PM +0100, Hofmann Johannes wrote:
On Thu, Mar 12, 2009 at 10:36:08AM +0000, Jeremy Henty wrote:
I wrote:
a_Bw_stop_clients() is always called with the BW_Root and BW_Img flags set, so we can remove those flags. That leaves only the BW_Force flag, so we can remove that too and change the flags argument to a boolean that indicates whether to force.
What's the verdict on this? I haven't seen any comments. I have some other cleanups and refactoring to propose and some of those patches depend on this one, so it would be good know whether or not it will go in so I can ready the rest for submission.
Sorry, I can't comment on this one as I don't know the relevant code enough. Let's wait for Jorge to comment.
Sorry, I've had little time latelely... Anyway I reviewed the patch back then, and remembered that the current interface was meant for flexibility to experiment. The smantics for STOP were/are not well defined yet, and so the flags API lingered. I have to give it a second review. Anyway, if there're more cleanups pending on this patch, it may be worth accepting them and at worst to re-introduce the flags when STOP semantics get high priority (if ever). -- Cheers Jorge.-