Hi Matthias! Hope you're doing well there in Munich. :-) On Tue, Mar 28, 2006 at 09:18:47PM +0200, Matthias Franz wrote:
Hi Jorge,
I have found the following small problem in html.c:
the comparison of HTML versions in Html_parse_entity does not work, apparently because of floating point roundoff errors: On my machine (i386, Debian Sarge, libc6), the comparison (lines 1016ff)
if ((html->DocType == DT_HTML && html->DocTypeVersion == 4.01) || html->DocType == DT_XHTML) MSG_HTML("undefined character entity '%s'\n", tok);
is never triggered for HTML 4.01. In fact, html->DocTypeVersion - 4.01 has the value 2.288818e-07. Currently this is the only place where such a comparison is used, but I guess this might change in future.
I just commited a patch to the CVS for this. Please test it and send some feedback. Note: this is not in rc3. I decided to put rc3 up to have the big patch tested while I work on this other small bugs. -- Cheers Jorge.-