On Sat, Jun 14, 2008 at 04:14:32PM +0100, Jeremy Henty wrote:
A set of small patches that clean up form.cc , mostly to do with DilloHtmlSelect .
* refactor by creating new functions: - a_Html_parse_stash() - DilloHtmlSelect::ensureSelection() - DilloHtmlSelect::addOptionsTo() - DilloHtmlSelect::appendValuesTo() - DilloHtmlSelect::getCurrentOption() (cf. other getCurrent* methods) * make DilloHtmlSelect::options private * rename DilloHtmlInput::getInputValues() to appendValuesTo() (the new name is more mnemonic and consistent with the DilloHtmlSelect method above)
Committed, except 00 and 05. 00: The stash buffer may hold a script, in that case parse_stash is not as clear as parse_entities. 05: gives compilation errors: [...] form.cc: In function 'void Html_option_finish(DilloHtml*)': form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* DilloHtmlSelect::options' is private form.cc:1918: error: within this context form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* DilloHtmlSelect::options' is private form.cc:1918: error: within this context -- Cheers Jorge.-