On Thu, Nov 12, 2009 at 04:28:05AM +0000, corvid wrote:
Jorge wrote:
On Thu, Nov 12, 2009 at 12:08:33AM +0000, corvid wrote:
Jorge wrote:
BTW, I chasing a very weird bug here. I can't modify a bookmark unless I comment closing a stream on an unrelated file!
This is:
@@ -417,8 +417,10 @@ static int Dpi_read_comm_keys(int *port) SharedKey[i] = 0; ret = 1; } - if (In) - fclose(In);
Then it works! :-P
@all: The question is, is this happening only in my system or do you see the problem as well. In other words: can you modify a bookmark?
I don't normally use bookmarks, but if I try it, I click submit, get Nav_open_url: new url='dpi:/bm/modify?operation=modify&submit=submit.&s0=on&url1=on' Nav_open_url: new url='dpi:/bm/modify'
and...nothing else seems to happen.
Exactly as here...
and if you apply the above patch?
Yup, I get a new page for updating the title.
There were two bugs in this problem: a FD leak, and an obscure bug with socket closing. I committed a workaround that makes it work. The last thing to blame is external libraries or the kernel itself, but this bug is weird enough to keep the possibility open. Not closing a completely unrelated stream (above-quoted patch) also made it work. This makes me think that something happens in the OS' FD handling code. The committed workaround is a usleep(2) before closing the socket (which shouldn't be necessary AFAIU because as from the SPEC, in that case the socket must deliver in background). I've tried with different kernels (and glibc) and the same bug shows. Corvid also reported it. The question is: Is anyone using *BSD seeing it? Note: the bug is not being able to see bookmark's "Add Section" page. Go to modify, select "add section", and submit. If you see the page, there's no bug. Note2: please test with and without the workaround patch! ;) -- Cheers Jorge.-