Hi, On Sun, Aug 11, 2024 at 01:41:44AM +0200, a1ex@dismail.de wrote:
Hi Rodrigo,
Looking at your recent commit:
Make Dillo strictly C99, C++11 and POSIX-2001 compliant, without depending on GNU extensions.
Right now the OpenBSD port of Dillo is dependent on gmake (GNU make) to build the package.
Out of curiosity, I tried to use the native 'make' command:
$ make
[...] Making all in doc Using $< in a non-suffix rule context is a GNUmake idiom (Makefile:556) *** Error 1 in . (Makefile:583 'all-recursive') *** Error 2 in . (Makefile:380 'all')
Everything else builds fine, except this error in doc.
Here is the offending line:
$ diff -up a/doc/Makefile.am b/doc/Makefile.am --- a/doc/Makefile.am Sun Aug 11 00:01:58 2024 +++ b/doc/Makefile.am Sun Aug 11 00:01:51 2024 @@ -11,6 +11,6 @@ dillo.1: $(srcdir)/dillo.1.in Makefile
# Use .in.html instead of .html.in so it is recognized as HTML. user_help.html: $(srcdir)/user_help.in.html Makefile - sed 's/__VERSION__/${VERSION}/g' $< > $@
DISTCLEANFILES = dillo.1 user_help.html
With that removed, there are no errors.
We need that sed command to adjust the version in the generated documentation. I didn't knew $< was a GNU extension, but this patch should fix it: diff --git a/doc/Makefile.am b/doc/Makefile.am index 943e70d7..ae2ccd5d 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -11,6 +11,6 @@ dillo.1: $(srcdir)/dillo.1.in Makefile # Use .in.html instead of .html.in so it is recognized as HTML. user_help.html: $(srcdir)/user_help.in.html Makefile - sed 's/__VERSION__/${VERSION}/g' $< > $@ + sed 's/__VERSION__/${VERSION}/g' $(srcdir)/user_help.in.html > $@ DISTCLEANFILES = dillo.1 user_help.html Thanks!, Rodrigo.