----------------------------------------
From: corvid@lavabit.com Date: Sun, 15 May 2011 22:34:00 +0000 To: dillo-dev@dillo.org Subject: [Dillo-dev] configure.in -Wno-unused-parameter
if eval "test x$GCC = xyes"; then .. if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then CFLAGS="$CFLAGS -W -Wno-unused-parameter" fi fi .. fi
It checks for 3.x specifically. 3.0 came out on June 18, 2001.
And of course 4.x has been out since...let's see...April 20, 2005.
2.95 was still apparently around back in http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , which prompted this code at the time.
Can I rip out the version-checking and make it into an ordinary case of adding the argument if it isn't already in CFLAGS?
As an aside, why not change -W to -Wextra? ?While they are both supported, the gcc manual encourages the use of -Wextra. ?My guess is that -W will eventually be deprecated. ?On the other hand, how far back does gcc support -Wextra? ?I cannot remember when that change was made.