Hi Tim, On Mon, Mar 09, 2009 at 04:54:57PM +0100, Tim Nieradzik wrote:
Here is an updated version of the patch. It aims to be fully backward compatible. You do not need to change anything in your dillorc (put the key bindings into ~/.dillo/keysrc).
Good.
Changes: - Ported src/dir\.[ch] to C++ (now called src/paths\.(cc|hh)). - Split src/prefs.c (parser is now in src/prefsparser.c). - Changed method names in src/dillo.cc to use camel case. - Added meta-modifier and function keys F10-F12. - Fixed some inconsistent white spaces. - Shortened some license headers. - Key bindings are to be defined in keysrc (previously dillorc). - Minor code cleanups such as using "TODO:" instead of "\todo". - Removed a_Prefs_freeall because it was not used anywhere.
After giving a couple of read-passes to the patch, and considering that we still have some time before April (when I'll have time to focus on the release), we can merge this long patch in small independent chunks. Please separate them into different patch files. For instance: Simple ones: - Changed method names in src/dillo.cc to use camel case. - Fixed some inconsistent white spaces. - Shortened some license headers. - Minor code cleanups such as using "TODO:" instead of "\todo". - Removed a_Prefs_freeall because it was not used anywhere. Refactors: - Split src/prefs.c (parser is now in src/prefsparser.c). Core of it: - Key bindings are to be defined in keysrc (previously dillorc). - Added meta-modifier and function keys F10-F12.
PS: I would like to port some C files to C++ in order to achieve more consistency. What is your opinion on this?
As explained before. Not unless we're forced or there's a compelling reason. For instance I'd decline this: - Ported src/dir\.[ch] to C++ (now called src/paths\.(cc|hh)). (unless there's a strong reason I've not seen). -- Cheers Jorge.-