On Thu, Sep 25, 2003 at 09:17:12PM +0200, Andreas Schweitzer wrote:
I'm guessing almost everybody wants to have frames, so maybe removing the conditional compilation of frames is worthwhile for the sake of simplifying code.
Not only everybody *wants* it. Afterall, frames are part of the HTML standard. So it makes sense to have them.
But then again, as far as I understood some of the last e-mails from Jorge : isn't he reviewing this patch now or pretty soon ?
It was in reaction to comments from Sebastian that I posed this question to the list. He suggested removing the conditional compile, but I want to know what the list has to say on this. As a quick look at the list archives will show, not everyone likes these new additions to Dillo. I have already removed some preferences which could be combined (frame_blank_in_tab and tab_on_middle_click -> tab_instead_of_window) or which should be defaulted to the new functionality (document_title_use_url). Other suggestions Sebastian made are: - Remove tab title compression/shortening (I might create a new label widget which compresses/shortens text to a given size for this functionality) - exchange tab_load_in_background with a UI element/choice (I think this should be delayed until Dillo has a preference UI/plugin to avoid unnecessary complexity and one-off solutions) - rename "DilloDoc" to something else (I do not agree, DilloDoc is descriptive and short) The current state of the patch is: - still have conditional compile - have removed unnecessary preferences - have removed some recent changes to CVS nav.c which conflict with document/interface separation (have mailed Jorge about this) - have added incremental search and status-bar search widget (instead of popup) I will release a new version today or tomorrow Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]