Hi, On Sat, Jun 01, 2024 at 09:06:44AM -0600, pastebin@gmx.com wrote:
Yes, you can send them to my email. Not sure what format sylpheed uses, but I will try to convert them to mbox and merge what is missing.
see my private email to you
Just got it now, thanks!
see attached pngs
1.png 'save page as file' dialog - dialog size i want
2.png 'save page as file' dialog - file already exists - dialog size i want
3.png 'file exists' dialog - is the same size as 'save page as file' dialog - the size is to large for what i want so if i reduce the dimensions - the next 'save page as file' dialog i get will be to small (the same size as what i made the 'file exists' dialog
As a general note, in your pictures I see you are loading /root directly from Dillo, which suggest you are running Dillo as root. I would really avoid doing that while browsing, as any potential remote code execution we could have would give an attacker immediate root access on your machine (among other issues).
dillo saves one dimension size for the two dialog boxes maybe 2 separate size dimensions for 'save page as file' and 'file exists' dialog
If you have a working patch I could merge it into 3.1.1. Otherwise I can queue it among the other issues, as I would need to investigate further how to solve it. I have a patch somewhere that switches to a native file picker, which may solve one of the problems (it also remembers where you saved the last file). But this will probably be added in 3.2.0, as I'm finishing bug fixes for 3.1.1 (no more features for now).
do don't get ssl dialog warning when connecting to https site and does connection
src.IO.tls.c /* 3.0.5 modification choice = a_Dialog_choice(title, dialog_warning_msg, "Continue", "Cancel", NULL); if (choice == 1) { ret = 0; } */ ret = 0; dFree(dialog_warning_msg); } } dFree(title);
This shouldn't be a problem now, as the annoying pop-ups are fixed. But they still show when there is an actual problem with the TLS certificates, in which case you *don't* want to ignore them by default.
-
src.prefs.c /* 3.0.5 modification #define PREFS_HOME "http://www.dillo.org/" */ #define PREFS_HOME ""
src.ui.cc /* 3.0.5 modification StatusOutput->value("http://www.dillo.org"); */ StatusOutput->value("");
-
These are fixed too. You can configure the home address to another value in dillorc with the "home" option, no need to patch Dillo.
src.menu.cc /* 3.0.5 modification static Menu_popup_data_t page_data = {"Page menu", NULL, pm}; */ static Menu_popup_data_t page_data = {NULL, NULL, pm};
src.menu.cc /* 3.0.5 modification static Menu_popup_data_t image_data = {"Image menu", NULL, pm}; */ static Menu_popup_data_t image_data = {NULL, NULL, pm};
src.menu.cc /* 3.0.5 modification static Menu_popup_data_t form_data = {"Form menu", NULL, pm}; */ static Menu_popup_data_t form_data = {NULL, NULL, pm};
---
I think these are useful to be seen, as it may happen that you are clicking accidentally on an image that is larger than it look like, and the menu is not what you would expect.
and changing position of dialog buttons i will post them in case someone else wants them -
This may be useful, as sometimes they open in weird positions.
i didn't do this for 3.0.5 (just for earlier versions - i forgot to do it for 3.0.5 and it was okay :)
For the future, if you work with git (recommended), you can format your patches with `git format-patch` so they can be applied directly. Or with `git send-email` so you also include the patch message and other metadata. Alternatively, please format patches with `patch -up` so they are easy to integrate. Best, Rodrigo.