Johannes wrote:
On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote:
dillo: - I imagine the setUseMap() in open_img() is probably supposed to be routed through DilloImage. - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. For one thing, the old code couldn't handle whitespace preceding a comma. - I didn't really like that dReturn_if_fail so far down in open_area() since coords is dynamically allocated now, but I left it there.
What about deleting coords earlier? I think they are no longer needed once the shape has been constructed.
That's true. I had just reached a point where the code was already tested and I didn't want to mess with anything for fear of introducing some error at the last moment ("this doesn't work at all! did you even compile it?" :))
Regarding your comment in Image::enterNotifyImpl(). I noticed that too, but enterNotifyImpl() simply notifies about the enter event, so no coordinates are needed. Don't you think that implementing map aware Image::motionNotifyImpl() is enough?
You're probably right. I wasn't sure whether it would get a motionNotify when it first entered the image. Speaking of motionNotify, the other day I was looking into getting the link in the status bar to change when scrolling. I'd gotten as far as figuring out that maybe *checks notes* Layout::scrollPosChanged could call Layout::motionNotify, but then I got stuck because I didn't know where to get current cursor coordinates from.