On Thu, Jun 05, 2008 at 03:48:53PM +0100, Jeremy Henty wrote:
On Thu, Jun 05, 2008 at 09:02:28AM -0400, Jorge Arellano Cid wrote:
On Wed, Jun 04, 2008 at 03:38:38PM +0100, Jeremy Henty wrote:
The next step is to move some of the function declarations across, but that depends on deciding what to do with the function names. Should I rename "Html_*" to "a_Html_*"?
I'd prefer to have C functions called from other sources as a_Html_*.
OK, but how does that rule apply to Html_tag_{open,close}_*() ? They aren't explicitly called anywhere,
They are called by the parser from inside html.cc.
just referenced from the Tags array in html.cc . The split will move some of them into form.cc . It would be ugly to rename some of them but not others. If the plan is to move most or all of them to separate files like form.cc (which I think would be a good way to split up html.cc) then perhaps we should rename them all to a_Html_tag_{open,close}_*() in advance?
As the Html_tag_{open,close}_*() functions are closely related to the parser, I'd prefer to have them not renamed. If there's a need, these functions could call a_Form_*() functions. Something like: Html_open_form () { [...] a_Form_do_something() [...] } -- Cheers Jorge.-