On Sun, Dec 28, 2008 at 05:30:07PM +0000, corvid wrote:
Johannes wrote:
On Thu, Dec 25, 2008 at 10:43:06AM -0300, Jorge Arellano Cid wrote:
Hi,
On Sun, Dec 21, 2008 at 04:48:42PM -0300, Jorge Arellano Cid wrote:
Hi Johannes,
Here I'm attaching the second part of the CSS loading patch. This one is coherent and works better :-). Please commit after some testing.
Note: images are still truncated sometimes, but AFAIS this is a problem in the dicache, not in CSS loading. I hope to fix this soon.
Well, in fact, images were always truncated when the repush caught them still rendering.
I've been working on this for days and yes, it's a problem in the dicache. Unfortunately the cache/dicache/image-decode/image code is so entangled that it needs a rewrite. Quite surprising it works stable "as is".
BTW, what about removing the dicache altogether? Or is anyone using use_dicache=YES ?
fltk-era dillo always behaved like use_dicache=NO, and I took out the pref some months ago. I wanted to rip out the dicache at one point, but ran into the entanglement mentioned above. A simple ripping-out didn't look like it was going to work because something needed to associate URLs with imgbufs and so on...
Exactly. The dicache serves as a link between the image decoder and the image widget. It also provides versioned images. I have progressed a lot and the new code works quite well in my tree. After some assorted testing, there's still a segfault that I want to chase before showing the code. The rest of it works OK. (i.e. CSS with no half images). -- Cheers Jorge.-