On Fri, 29 Jul 2011 16:12:12 -0400, Jorge Arellano Cid <jcid@dillo.org> wrote:
This avoids the dialog bombing that stems from loading multiple https images/resources in a single page. A proper fix would take either to implement the https-dpi as a server (with state), or to move back https handling into dillo.
As both paths would take considerable effort, and taking into account that even deciding which approach/library to use is non trivial, the workaround looks like a good compromise.
Actually, the second one's already done -- I implemented it as part of Dillo-Win32. The patches of interest are: http://dillo-win32.sourceforge.net/files/03-dillo-r1819.dsock.diff http://dillo-win32.sourceforge.net/files/22-dillo-r1819.https.diff http://dillo-win32.sourceforge.net/files/24-dillo-r1819.sslconfig.diff The first one introduces dsock, a sockets abstraction layer patterned on dlib, which I originally wrote to add Windows networking support. The next one extends dsock to provide SSL support: all you need to do is tell it to "go secure," then dsock handles read/write operations transparently. So you get both portability *and* security, with only minimal modification to the existing Dillo code. The last patch is optional -- it just modifies the ./configure script so it can link against CyaSSL[1], an embedded SSL library. It's probably not as useful on Unix, since every distro these days ships OpenSSL, but it's nice on Windows since it dramatically reduces the binary's download size. There are a couple caveats: the HTTP CONNECT code is a mess right now, because I couldn't figure how to hook that through the CCC's, and I haven't yet added the SSL dialogs. But both of those should be relatively easy to fix. [1] http://www.yassl.com/yaSSL/Home.html Just thought I'd share, ~Benjamin